Skip to content

Commit

Permalink
ieee1394: eth1394: remove bogus netif_wake_queue
Browse files Browse the repository at this point in the history
When we are within hard_start_xmit, the queue is already awake.

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
  • Loading branch information
Stefan Richter committed May 27, 2007
1 parent 20e2008 commit 69c29fa
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions drivers/ieee1394/eth1394.c
Original file line number Diff line number Diff line change
Expand Up @@ -1636,7 +1636,6 @@ static int ether1394_tx(struct sk_buff *skb, struct net_device *dev)
if (ether1394_send_packet(ptask, tx_len))
goto fail;

netif_wake_queue(dev);
return NETDEV_TX_OK;
fail:
if (ptask)
Expand All @@ -1650,9 +1649,6 @@ static int ether1394_tx(struct sk_buff *skb, struct net_device *dev)
priv->stats.tx_errors++;
spin_unlock_irqrestore(&priv->lock, flags);

if (netif_queue_stopped(dev))
netif_wake_queue(dev);

/*
* FIXME: According to a patch from 2003-02-26, "returning non-zero
* causes serious problems" here, allegedly. Before that patch,
Expand Down

0 comments on commit 69c29fa

Please sign in to comment.