Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 377601
b: refs/heads/master
c: a115f74
h: refs/heads/master
i:
  377599: 6bf9df4
v: v3
  • Loading branch information
Jan Kara authored and Theodore Ts'o committed Jun 4, 2013
1 parent ffaf4cd commit 6a06ca6
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 8 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: e83403959fddb6d90e8c5e54bbce3110d0c82165
refs/heads/master: a115f749c14ee94e8b7bdbd203a5afdb1659156b
6 changes: 0 additions & 6 deletions trunk/fs/ext4/inode.c
Original file line number Diff line number Diff line change
Expand Up @@ -3643,12 +3643,6 @@ void ext4_truncate(struct inode *inode)
return;
}

/*
* finish any pending end_io work so we won't run the risk of
* converting any truncated blocks to initialized later
*/
ext4_flush_unwritten_io(inode);

if (ext4_test_inode_flag(inode, EXT4_INODE_EXTENTS))
credits = ext4_writepage_trans_blocks(inode);
else
Expand Down
9 changes: 8 additions & 1 deletion trunk/fs/ext4/page-io.c
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,14 @@ static void ext4_clear_io_unwritten_flag(ext4_io_end_t *io_end)
wake_up_all(ext4_ioend_wq(inode));
}

/* check a range of space and convert unwritten extents to written. */
/*
* Check a range of space and convert unwritten extents to written. Note that
* we are protected from truncate touching same part of extent tree by the
* fact that truncate code waits for all DIO to finish (thus exclusion from
* direct IO is achieved) and also waits for PageWriteback bits. Thus we
* cannot get to ext4_ext_truncate() before all IOs overlapping that range are
* completed (happens from ext4_free_ioend()).
*/
static int ext4_end_io(ext4_io_end_t *io)
{
struct inode *inode = io->inode;
Expand Down

0 comments on commit 6a06ca6

Please sign in to comment.