Skip to content

Commit

Permalink
asus-wmi: move WAPF variable into quirks_entry
Browse files Browse the repository at this point in the history
Some models work better with different values of wapf, so move the
variable into quriks_entry to make it more easy to give a specific
value to different models.

Based on original patch from AceLan Kao <acelan.kao@canonical.com>

Cc: AceLan Kao <acelan.kao@canonical.com>
Signed-off-by: Corentin Chary <corentin.chary@gmail.com>
Signed-off-by: Matthew Garrett <mjg@redhat.com>
  • Loading branch information
Corentin Chary authored and Matthew Garrett committed Mar 26, 2012
1 parent 6e0044b commit 6a2bccc
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 5 deletions.
6 changes: 5 additions & 1 deletion drivers/platform/x86/asus-nb-wmi.c
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,13 @@ static uint wapf;
module_param(wapf, uint, 0444);
MODULE_PARM_DESC(wapf, "WAPF value");

static struct quirk_entry quirk_asus_unknown = {
};

static void asus_nb_wmi_quirks(struct asus_wmi_driver *driver)
{
driver->wapf = wapf;
driver->quirks = &quirk_asus_unknown;
driver->quirks->wapf = wapf;
}

static const struct key_entry asus_nb_wmi_keymap[] = {
Expand Down
4 changes: 2 additions & 2 deletions drivers/platform/x86/asus-wmi.c
Original file line number Diff line number Diff line change
Expand Up @@ -1471,9 +1471,9 @@ static int asus_wmi_platform_init(struct asus_wmi *asus)

/* CWAP allow to define the behavior of the Fn+F2 key,
* this method doesn't seems to be present on Eee PCs */
if (asus->driver->wapf >= 0)
if (asus->driver->quirks->wapf >= 0)
asus_wmi_set_devstate(ASUS_WMI_DEVID_CWAP,
asus->driver->wapf, NULL);
asus->driver->quirks->wapf, NULL);

return asus_wmi_sysfs_init(asus->platform_device);
}
Expand Down
2 changes: 1 addition & 1 deletion drivers/platform/x86/asus-wmi.h
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,10 @@ struct quirk_entry {
bool hotplug_wireless;
bool scalar_panel_brightness;
bool store_backlight_power;
int wapf;
};

struct asus_wmi_driver {
int wapf;
int brightness;
int panel_power;

Expand Down
2 changes: 1 addition & 1 deletion drivers/platform/x86/eeepc-wmi.c
Original file line number Diff line number Diff line change
Expand Up @@ -209,10 +209,10 @@ static int eeepc_wmi_probe(struct platform_device *pdev)

static void eeepc_wmi_quirks(struct asus_wmi_driver *driver)
{
driver->wapf = -1;
driver->panel_power = FB_BLANK_UNBLANK;
driver->quirks = &quirk_asus_unknown;
driver->quirks->hotplug_wireless = hotplug_wireless;
driver->quirks->wapf = -1;
dmi_check_system(asus_quirks);
driver->quirks = quirks;
}
Expand Down

0 comments on commit 6a2bccc

Please sign in to comment.