Skip to content

Commit

Permalink
[PATCH] fix AUDIT_FILTER_PREPEND handling
Browse files Browse the repository at this point in the history
Clear AUDIT_FILTER_PREPEND flag after adding rule to list.  This
fixes three problems when a rule is added with the -A syntax:

    - auditctl displays filter list as "(null)"
    - the rule cannot be removed using -d
    - a duplicate rule can be added with -a

Signed-off-by: Amy Griffis <amy.griffis@hp.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
  • Loading branch information
Amy Griffis authored and Al Viro committed Jun 20, 2006
1 parent 0a73dcc commit 6a2bcee
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions kernel/auditfilter.c
Original file line number Diff line number Diff line change
Expand Up @@ -1083,6 +1083,7 @@ static inline int audit_add_rule(struct audit_entry *entry,

if (entry->rule.flags & AUDIT_FILTER_PREPEND) {
list_add_rcu(&entry->list, list);
entry->rule.flags &= ~AUDIT_FILTER_PREPEND;
} else {
list_add_tail_rcu(&entry->list, list);
}
Expand Down

0 comments on commit 6a2bcee

Please sign in to comment.