Skip to content

Commit

Permalink
staging: iio: lis3l02dq add _type attributes for all scan elements
Browse files Browse the repository at this point in the history
Also, adds a macro to make defining such attributes simple.

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Manuel Stahl <manuel.stahl@iis.fraunhofer.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Jonathan Cameron authored and Greg Kroah-Hartman committed Sep 21, 2010
1 parent cf2b448 commit 6a36e61
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 1 deletion.
4 changes: 4 additions & 0 deletions drivers/staging/iio/accel/lis3l02dq_ring.c
Original file line number Diff line number Diff line change
Expand Up @@ -84,13 +84,17 @@ static IIO_SCAN_EL_C(accel_y, 1, IIO_SIGNED(16),
static IIO_SCAN_EL_C(accel_z, 2, IIO_SIGNED(16),
LIS3L02DQ_REG_OUT_Z_L_ADDR,
&lis3l02dq_scan_el_set_state);
static IIO_CONST_ATTR_SCAN_EL_TYPE(accel, s, 12, 16);
static IIO_SCAN_EL_TIMESTAMP(3);
static IIO_CONST_ATTR_SCAN_EL_TYPE(timestamp, s, 64, 64);

static struct attribute *lis3l02dq_scan_el_attrs[] = {
&iio_scan_el_accel_x.dev_attr.attr,
&iio_scan_el_accel_y.dev_attr.attr,
&iio_scan_el_accel_z.dev_attr.attr,
&iio_const_attr_accel_type.dev_attr.attr,
&iio_scan_el_timestamp.dev_attr.attr,
&iio_const_attr_timestamp_type.dev_attr.attr,
NULL,
};

Expand Down
11 changes: 10 additions & 1 deletion drivers/staging/iio/ring_generic.h
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ ssize_t iio_scan_el_ts_show(struct device *dev, struct device_attribute *attr,
.bit_count = _bits, \
.label = _label, \
.set_state = _controlfunc, \
}
}

#define IIO_SCAN_EL_C(_name, _number, _bits, _label, _controlfunc) \
__IIO_SCAN_EL_C(_name, _number, _bits, _label, _controlfunc)
Expand Down Expand Up @@ -279,6 +279,15 @@ ssize_t iio_scan_el_ts_show(struct device *dev, struct device_attribute *attr,
iio_scan_el_ts_store), \
}

/**
* IIO_CONST_ATTR_SCAN_EL_TYPE - attr to specify the data format of a scan el
* @name: the scan el name (may be more general and cover a set of scan elements
* @_sign: either s or u for signed or unsigned
* @_bits: number of actual bits occuplied by the value
* @_storagebits: number of bits _bits is padded to when read out of buffer
**/
#define IIO_CONST_ATTR_SCAN_EL_TYPE(_name, _sign, _bits, _storagebits) \
IIO_CONST_ATTR(_name##_type, #_sign#_bits"/"#_storagebits);
/*
* These are mainly provided to allow for a change of implementation if a device
* has a large number of scan elements
Expand Down

0 comments on commit 6a36e61

Please sign in to comment.