Skip to content

Commit

Permalink
MTD: [NAND] Fix the sharpsl driver after breakage from a core conversion
Browse files Browse the repository at this point in the history
The CNE bits are inverted on the device and writeb function is missing a
NOT operation.

Signed-off-by: Richard Purdie <rpurdie@rpsys.net>
Signed-off-by: David Woodhouse <dwmw2@infradead.org>
  • Loading branch information
Richard Purdie authored and David Woodhouse committed Jul 15, 2006
1 parent 8b0036e commit 6a5a297
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions drivers/mtd/nand/sharpsl.c
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ static struct mtd_partition sharpsl_nand_default_partition_info[] = {
/*
* hardware specific access to control-lines
* ctrl:
* NAND_CNE: bit 0 -> bit 0 & 4
* NAND_CNE: bit 0 -> ! bit 0 & 4
* NAND_CLE: bit 1 -> bit 1
* NAND_ALE: bit 2 -> bit 2
*
Expand All @@ -92,7 +92,10 @@ static void sharpsl_nand_hwcontrol(struct mtd_info *mtd, int cmd,
unsigned char bits = ctrl & 0x07;

bits |= (ctrl & 0x01) << 4;
writeb((readb(FLASHCTL) & 0x17) | bits, FLASHCTL);

bits ^= 0x11;

writeb((readb(FLASHCTL) & ~0x17) | bits, FLASHCTL);
}

if (cmd != NAND_CMD_NONE)
Expand Down

0 comments on commit 6a5a297

Please sign in to comment.