Skip to content

Commit

Permalink
splice: fix bad unlock_page() in error case
Browse files Browse the repository at this point in the history
If add_to_page_cache_lru() fails, the page will not be locked. But
splice jumps to an error path that does a page release and unlock,
causing a BUG() in unlock_page().

Fix this by adding one more label that just releases the page. This bug
was actually triggered on EL5 by gurudas pai <gurudas.pai@oracle.com>
using fio.

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Jens Axboe authored and Linus Torvalds committed Jul 20, 2007
1 parent 9d1ca6f commit 6a860c9
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions fs/splice.c
Original file line number Diff line number Diff line change
Expand Up @@ -594,7 +594,7 @@ static int pipe_to_file(struct pipe_inode_info *pipe, struct pipe_buffer *buf,
ret = add_to_page_cache_lru(page, mapping, index,
GFP_KERNEL);
if (unlikely(ret))
goto out;
goto out_release;
}

ret = mapping->a_ops->prepare_write(file, page, offset, offset+this_len);
Expand Down Expand Up @@ -650,8 +650,9 @@ static int pipe_to_file(struct pipe_inode_info *pipe, struct pipe_buffer *buf,
*/
mark_page_accessed(page);
out:
page_cache_release(page);
unlock_page(page);
out_release:
page_cache_release(page);
out_ret:
return ret;
}
Expand Down

0 comments on commit 6a860c9

Please sign in to comment.