Skip to content

Commit

Permalink
Bluetooth: mgmt: Initialize HCI_MGMT flag for any command
Browse files Browse the repository at this point in the history
The read_controller_info is typically the first command that user space
sends when taking a controller into use. This is also the reason why
this command has been used as the trigger to set the HCI_MGMT flag.
However, when not running the user-space daemon and using command line
tools it is possible that read_controller_info is not the first
controller specific command. This patch moves the HCI_MGMT
initialization to a generic place where it will be set for whatever
happens to be the first mgmt command targetting a specific controller.

Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>
Acked-by: Marcel Holtmann <marcel@holtmann.org>
  • Loading branch information
Johan Hedberg committed Mar 1, 2012
1 parent bdb6d97 commit 6a91908
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions net/bluetooth/mgmt.c
Original file line number Diff line number Diff line change
Expand Up @@ -610,8 +610,11 @@ static void service_cache_off(struct work_struct *work)
hci_dev_unlock(hdev);
}

static void mgmt_init_hdev(struct hci_dev *hdev)
static void mgmt_init_hdev(struct sock *sk, struct hci_dev *hdev)
{
if (!test_and_clear_bit(HCI_PI_MGMT_INIT, &hci_pi(sk)->flags))
return;

if (!test_and_set_bit(HCI_MGMT, &hdev->dev_flags)) {
INIT_DELAYED_WORK(&hdev->service_cache, service_cache_off);

Expand All @@ -632,9 +635,6 @@ static int read_controller_info(struct sock *sk, struct hci_dev *hdev)

hci_dev_lock(hdev);

if (test_and_clear_bit(HCI_PI_MGMT_INIT, &hci_pi(sk)->flags))
mgmt_init_hdev(hdev);

memset(&rp, 0, sizeof(rp));

bacpy(&rp.bdaddr, &hdev->bdaddr);
Expand Down Expand Up @@ -2764,6 +2764,8 @@ int mgmt_control(struct sock *sk, struct msghdr *msg, size_t msglen)
MGMT_STATUS_INVALID_PARAMS);
goto done;
}

mgmt_init_hdev(sk, hdev);
}

cp = buf + sizeof(*hdr);
Expand Down

0 comments on commit 6a91908

Please sign in to comment.