Skip to content

Commit

Permalink
[PATCH] bonding: fix ->get_settings error checking
Browse files Browse the repository at this point in the history
Since get_settings() returns a signed int and it gets checked
for < 0 to catch an error, res should be a signed int too.

Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: Jeff Garzik <jgarzik@pobox.com>
  • Loading branch information
Eric Sesterhenn authored and Jeff Garzik committed Jan 27, 2006
1 parent 3ee68c4 commit 6a986ce
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/net/bonding/bond_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -576,7 +576,7 @@ static int bond_update_speed_duplex(struct slave *slave)
slave->duplex = DUPLEX_FULL;

if (slave_dev->ethtool_ops) {
u32 res;
int res;

if (!slave_dev->ethtool_ops->get_settings) {
return -1;
Expand Down

0 comments on commit 6a986ce

Please sign in to comment.