---

yaml --- r: 129699 b: refs/heads/master c: 068b38c h: refs/heads/master i: 129697: 7cb6224 129695: c504d2d v: v3
git-mirror · Jan 16, 2009 · 6ac2533 · 6ac2533
1 parent 772563e
commit 6ac2533
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/[refs] b/[refs]
@@ -1,2 +1,2 @@
 ---
-refs/heads/master: 0eb253e223c88b982461e59154fcad1b82597592
+refs/heads/master: 068b38c1fa7a9210608f27ac521897ccc5f9b726
diff --git a/trunk/mm/memcontrol.c b/trunk/mm/memcontrol.c
@@ -1992,22 +1992,30 @@ static int mem_cgroup_swappiness_write(struct cgroup *cgrp, struct cftype *cft,
 {
 	struct mem_cgroup *memcg = mem_cgroup_from_cont(cgrp);
 	struct mem_cgroup *parent;
+
 	if (val > 100)
 		return -EINVAL;
 
 	if (cgrp->parent == NULL)
 		return -EINVAL;
 
 	parent = mem_cgroup_from_cont(cgrp->parent);
+
+	cgroup_lock();
+
 	/* If under hierarchy, only empty-root can set this value */
 	if ((parent->use_hierarchy) ||
-	    (memcg->use_hierarchy && !list_empty(&cgrp->children)))
+	    (memcg->use_hierarchy && !list_empty(&cgrp->children))) {
+		cgroup_unlock();
 		return -EINVAL;
+	}
 
 	spin_lock(&memcg->reclaim_param_lock);
 	memcg->swappiness = val;
 	spin_unlock(&memcg->reclaim_param_lock);
 
+	cgroup_unlock();
+
 	return 0;
 }