Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 213432
b: refs/heads/master
c: f6a5346
h: refs/heads/master
v: v3
  • Loading branch information
Jeff Layton authored and Steve French committed Oct 18, 2010
1 parent 4912403 commit 6b2e893
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 11 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 608712fe8609492a8670638ea86b97fafe49ebba
refs/heads/master: f6a53460e2a105904deeada737b3f878d78517b3
3 changes: 1 addition & 2 deletions trunk/fs/cifs/cifsproto.h
Original file line number Diff line number Diff line change
Expand Up @@ -107,8 +107,7 @@ extern struct timespec cnvrtDosUnixTm(__le16 le_date, __le16 le_time,

extern struct cifsFileInfo *cifs_new_fileinfo(struct inode *newinode,
__u16 fileHandle, struct file *file,
struct tcon_link *tlink,
unsigned int oflags, __u32 oplock);
struct tcon_link *tlink, __u32 oplock);
extern int cifs_posix_open(char *full_path, struct inode **pinode,
struct super_block *sb,
int mode, unsigned int f_flags,
Expand Down
9 changes: 4 additions & 5 deletions trunk/fs/cifs/dir.c
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ build_path_from_dentry(struct dentry *direntry)

struct cifsFileInfo *
cifs_new_fileinfo(struct inode *newinode, __u16 fileHandle, struct file *file,
struct tcon_link *tlink, unsigned int oflags, __u32 oplock)
struct tcon_link *tlink, __u32 oplock)
{
struct dentry *dentry = file->f_path.dentry;
struct cifsFileInfo *pCifsFile;
Expand Down Expand Up @@ -161,7 +161,7 @@ cifs_new_fileinfo(struct inode *newinode, __u16 fileHandle, struct file *file,
pCifsInode = CIFS_I(newinode);
if (pCifsInode) {
/* if readable file instance put first in list*/
if (oflags & FMODE_READ)
if (file->f_mode & FMODE_READ)
list_add(&pCifsFile->flist, &pCifsInode->openFileList);
else
list_add_tail(&pCifsFile->flist,
Expand Down Expand Up @@ -396,7 +396,7 @@ cifs_create(struct inode *inode, struct dentry *direntry, int mode,
}

pfile_info = cifs_new_fileinfo(newinode, fileHandle, filp,
tlink, oflags, oplock);
tlink, oplock);
if (pfile_info == NULL) {
fput(filp);
CIFSSMBClose(xid, tcon, fileHandle);
Expand Down Expand Up @@ -670,8 +670,7 @@ cifs_lookup(struct inode *parent_dir_inode, struct dentry *direntry,
}

cfile = cifs_new_fileinfo(newInode, fileHandle, filp,
tlink, nd->intent.open.flags,
oplock);
tlink, oplock);
if (cfile == NULL) {
fput(filp);
CIFSSMBClose(xid, pTcon, fileHandle);
Expand Down
5 changes: 2 additions & 3 deletions trunk/fs/cifs/file.c
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,7 @@ int cifs_open(struct inode *inode, struct file *file)
cFYI(1, "posix open succeeded");

pCifsFile = cifs_new_fileinfo(inode, netfid, file,
tlink, oflags, oplock);
tlink, oplock);
if (pCifsFile == NULL) {
CIFSSMBClose(xid, tcon, netfid);
rc = -ENOMEM;
Expand Down Expand Up @@ -365,8 +365,7 @@ int cifs_open(struct inode *inode, struct file *file)
if (rc != 0)
goto out;

pCifsFile = cifs_new_fileinfo(inode, netfid, file, tlink,
file->f_flags, oplock);
pCifsFile = cifs_new_fileinfo(inode, netfid, file, tlink, oplock);
if (pCifsFile == NULL) {
rc = -ENOMEM;
goto out;
Expand Down

0 comments on commit 6b2e893

Please sign in to comment.