Skip to content

Commit

Permalink
netxen: fix corner cases of firmware recovery
Browse files Browse the repository at this point in the history
Signed-off-by: Amit Kumar Salecha <amit.salecha@qlogic.com>

o DEV_NEED_RESET state was not handled during fw intialization phase.
o nx_decr_dev_ref_cnt() can return error, if fail to grab pcie seamphore.
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Amit Kumar Salecha authored and David S. Miller committed Mar 29, 2010
1 parent ff90cd4 commit 6b50ea1
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions drivers/net/netxen/netxen_nic_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -2294,6 +2294,7 @@ netxen_fwinit_work(struct work_struct *work)
}
break;

case NX_DEV_NEED_RESET:
case NX_DEV_INITALIZING:
if (++adapter->fw_wait_cnt < FW_POLL_THRESH) {
netxen_schedule_work(adapter,
Expand Down Expand Up @@ -2337,6 +2338,9 @@ netxen_detach_work(struct work_struct *work)

ref_cnt = nx_decr_dev_ref_cnt(adapter);

if (ref_cnt == -EIO)
goto err_ret;

delay = (ref_cnt == 0) ? 0 : (2 * FW_POLL_DELAY);

adapter->fw_wait_cnt = 0;
Expand Down

0 comments on commit 6b50ea1

Please sign in to comment.