Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 177450
b: refs/heads/master
c: 3e34059
h: refs/heads/master
v: v3
  • Loading branch information
Masami Hiramatsu authored and Ingo Molnar committed Dec 15, 2009
1 parent eff5cb1 commit 6b6de3a
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 6 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: f6bbff77252cf12c82d480eaf6d9189129d1040a
refs/heads/master: 3e3405906dab00afecd5a16871850a088eba4626
5 changes: 4 additions & 1 deletion trunk/tools/perf/util/probe-event.c
Original file line number Diff line number Diff line change
Expand Up @@ -540,10 +540,12 @@ static void del_trace_kprobe_event(int fd, const char *group,
const char *event, struct strlist *namelist)
{
char buf[128];
struct str_node *ent;

if (e_snprintf(buf, 128, "%s:%s", group, event) < 0)
die("Failed to copy event.");
if (!strlist__has_entry(namelist, buf)) {
ent = strlist__find(namelist, buf);
if (!ent) {
pr_info("Info: event \"%s\" does not exist, could not remove it.\n", buf);
return;
}
Expand All @@ -553,6 +555,7 @@ static void del_trace_kprobe_event(int fd, const char *group,

write_trace_kprobe_event(fd, buf);
printf("Remove event: %s:%s\n", group, event);
strlist__remove(namelist, ent);
}

void del_trace_kprobe_events(struct strlist *dellist)
Expand Down
6 changes: 3 additions & 3 deletions trunk/tools/perf/util/strlist.c
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ void strlist__remove(struct strlist *self, struct str_node *sn)
str_node__delete(sn, self->dupstr);
}

bool strlist__has_entry(struct strlist *self, const char *entry)
struct str_node *strlist__find(struct strlist *self, const char *entry)
{
struct rb_node **p = &self->entries.rb_node;
struct rb_node *parent = NULL;
Expand All @@ -120,10 +120,10 @@ bool strlist__has_entry(struct strlist *self, const char *entry)
else if (rc < 0)
p = &(*p)->rb_right;
else
return true;
return sn;
}

return false;
return NULL;
}

static int strlist__parse_list_entry(struct strlist *self, const char *s)
Expand Down
7 changes: 6 additions & 1 deletion trunk/tools/perf/util/strlist.h
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,12 @@ int strlist__load(struct strlist *self, const char *filename);
int strlist__add(struct strlist *self, const char *str);

struct str_node *strlist__entry(const struct strlist *self, unsigned int idx);
bool strlist__has_entry(struct strlist *self, const char *entry);
struct str_node *strlist__find(struct strlist *self, const char *entry);

static inline bool strlist__has_entry(struct strlist *self, const char *entry)
{
return strlist__find(self, entry) != NULL;
}

static inline bool strlist__empty(const struct strlist *self)
{
Expand Down

0 comments on commit 6b6de3a

Please sign in to comment.