Skip to content

Commit

Permalink
hwrng: omap - add missing clk_put
Browse files Browse the repository at this point in the history
Convert a return to a jump to an existing label that calls clk_put.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@r exists@
expression e1,e2;
statement S;
@@

e1 = clk_get@p1(...);
... when != e1 = e2
    when != clk_put(e1)
    when any
if (...) { ... when != clk_put(e1)
               when != if (...) { ... clk_put(e1) ... }
* return@p3 ...;
 } else S
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Matt Mackall <mpm@selenic.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
  • Loading branch information
Julia Lawall authored and Herbert Xu committed Jun 29, 2011
1 parent 8af0086 commit 6ba1a31
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions drivers/char/hw_random/omap-rng.c
Original file line number Diff line number Diff line change
Expand Up @@ -113,8 +113,10 @@ static int __devinit omap_rng_probe(struct platform_device *pdev)

res = platform_get_resource(pdev, IORESOURCE_MEM, 0);

if (!res)
return -ENOENT;
if (!res) {
ret = -ENOENT;
goto err_region;
}

if (!request_mem_region(res->start, resource_size(res), pdev->name)) {
ret = -EBUSY;
Expand Down

0 comments on commit 6ba1a31

Please sign in to comment.