Skip to content

Commit

Permalink
NFSv4.1: Use nfs41_setup_sequence where appropriate
Browse files Browse the repository at this point in the history
There is no point in using nfs4_setup_sequence or nfs4_sequence_done
in pure NFSv4.1 functions. We already know that those have sessions...

Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
  • Loading branch information
Trond Myklebust authored and Trond Myklebust committed Dec 5, 2012
1 parent c10e449 commit 6ba7db3
Showing 1 changed file with 9 additions and 6 deletions.
15 changes: 9 additions & 6 deletions fs/nfs/nfs4proc.c
Original file line number Diff line number Diff line change
Expand Up @@ -597,10 +597,11 @@ struct nfs41_call_sync_data {
static void nfs41_call_sync_prepare(struct rpc_task *task, void *calldata)
{
struct nfs41_call_sync_data *data = calldata;
struct nfs4_session *session = nfs4_get_session(data->seq_server);

dprintk("--> %s data->seq_server %p\n", __func__, data->seq_server);

if (nfs4_setup_sequence(data->seq_server, data->seq_args,
if (nfs41_setup_sequence(session, data->seq_args,
data->seq_res, task))
return;
rpc_call_start(task);
Expand Down Expand Up @@ -6018,14 +6019,15 @@ nfs4_layoutget_prepare(struct rpc_task *task, void *calldata)
{
struct nfs4_layoutget *lgp = calldata;
struct nfs_server *server = NFS_SERVER(lgp->args.inode);
struct nfs4_session *session = nfs4_get_session(server);

dprintk("--> %s\n", __func__);
/* Note the is a race here, where a CB_LAYOUTRECALL can come in
* right now covering the LAYOUTGET we are about to send.
* However, that is not so catastrophic, and there seems
* to be no way to prevent it completely.
*/
if (nfs4_setup_sequence(server, &lgp->args.seq_args,
if (nfs41_setup_sequence(session, &lgp->args.seq_args,
&lgp->res.seq_res, task))
return;
if (pnfs_choose_layoutget_stateid(&lgp->args.stateid,
Expand All @@ -6047,7 +6049,7 @@ static void nfs4_layoutget_done(struct rpc_task *task, void *calldata)

dprintk("--> %s\n", __func__);

if (!nfs4_sequence_done(task, &lgp->res.seq_res))
if (!nfs41_sequence_done(task, &lgp->res.seq_res))
goto out;

switch (task->tk_status) {
Expand Down Expand Up @@ -6211,7 +6213,7 @@ static void nfs4_layoutreturn_done(struct rpc_task *task, void *calldata)

dprintk("--> %s\n", __func__);

if (!nfs4_sequence_done(task, &lrp->res.seq_res))
if (!nfs41_sequence_done(task, &lrp->res.seq_res))
return;

server = NFS_SERVER(lrp->args.inode);
Expand Down Expand Up @@ -6360,8 +6362,9 @@ static void nfs4_layoutcommit_prepare(struct rpc_task *task, void *calldata)
{
struct nfs4_layoutcommit_data *data = calldata;
struct nfs_server *server = NFS_SERVER(data->args.inode);
struct nfs4_session *session = nfs4_get_session(server);

if (nfs4_setup_sequence(server, &data->args.seq_args,
if (nfs41_setup_sequence(session, &data->args.seq_args,
&data->res.seq_res, task))
return;
rpc_call_start(task);
Expand All @@ -6373,7 +6376,7 @@ nfs4_layoutcommit_done(struct rpc_task *task, void *calldata)
struct nfs4_layoutcommit_data *data = calldata;
struct nfs_server *server = NFS_SERVER(data->args.inode);

if (!nfs4_sequence_done(task, &data->res.seq_res))
if (!nfs41_sequence_done(task, &data->res.seq_res))
return;

switch (task->tk_status) { /* Just ignore these failures */
Expand Down

0 comments on commit 6ba7db3

Please sign in to comment.