Skip to content

Commit

Permalink
[PATCH] i2c: Rename i2c-parport variable to avoid confusion
Browse files Browse the repository at this point in the history
It's a bit confusing to name a variable the same as an unrelated
structure. The compiler doesn't complain, but it certainly makes the
code harder to understand, and could confuse grep and LXR among
others.

Signed-off-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Jean Delvare authored and Greg Kroah-Hartman committed Oct 28, 2005
1 parent 30dac74 commit 6c129be
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions drivers/i2c/busses/i2c-parport.c
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ static void i2c_parport_detach (struct parport *port)
}
}

static struct parport_driver i2c_driver = {
static struct parport_driver i2c_parport_driver = {
.name = "i2c-parport",
.attach = i2c_parport_attach,
.detach = i2c_parport_detach,
Expand All @@ -250,12 +250,12 @@ static int __init i2c_parport_init(void)
type = 0;
}

return parport_register_driver(&i2c_driver);
return parport_register_driver(&i2c_parport_driver);
}

static void __exit i2c_parport_exit(void)
{
parport_unregister_driver(&i2c_driver);
parport_unregister_driver(&i2c_parport_driver);
}

MODULE_AUTHOR("Jean Delvare <khali@linux-fr.org>");
Expand Down

0 comments on commit 6c129be

Please sign in to comment.