Skip to content

Commit

Permalink
proc: use WARN() rather than printk+backtrace
Browse files Browse the repository at this point in the history
Use WARN() rather than a printk() + backtrace();
this gives a more standard format message as well as complete
information (including line numbers etc) that will be collected
by kerneloops.org

Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
  • Loading branch information
Arjan van de Ven authored and Alexey Dobriyan committed Oct 23, 2008
1 parent 1e0edd3 commit 6c2f91e
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions fs/proc/generic.c
Original file line number Diff line number Diff line change
Expand Up @@ -547,9 +547,8 @@ static int proc_register(struct proc_dir_entry * dir, struct proc_dir_entry * dp

for (tmp = dir->subdir; tmp; tmp = tmp->next)
if (strcmp(tmp->name, dp->name) == 0) {
printk(KERN_WARNING "proc_dir_entry '%s/%s' already registered\n",
WARN(1, KERN_WARNING "proc_dir_entry '%s/%s' already registered\n",
dir->name, dp->name);
dump_stack();
break;
}

Expand Down

0 comments on commit 6c2f91e

Please sign in to comment.