Skip to content

Commit

Permalink
ARM: imx: use dynamic mapping for timer
Browse files Browse the repository at this point in the history
Pass physical address of timer block to mxc_timer_init() call, which in
turn does dynamic mapping within the function.  Thus, we can avoid using
static mapping in clock drivers.

Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
  • Loading branch information
Shawn Guo committed Jun 3, 2015
1 parent 0ed4668 commit 6c529c4
Show file tree
Hide file tree
Showing 7 changed files with 9 additions and 8 deletions.
2 changes: 1 addition & 1 deletion arch/arm/mach-imx/clk-imx1.c
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ int __init mx1_clocks_init(unsigned long fref)
clk_register_clkdev(clk[IMX1_CLK_DUMMY], "ipg", "imx1-fb.0");
clk_register_clkdev(clk[IMX1_CLK_DUMMY], "ahb", "imx1-fb.0");

mxc_timer_init(MX1_IO_ADDRESS(MX1_TIM1_BASE_ADDR), MX1_TIM1_INT);
mxc_timer_init(MX1_TIM1_BASE_ADDR, MX1_TIM1_INT);

return 0;
}
Expand Down
2 changes: 1 addition & 1 deletion arch/arm/mach-imx/clk-imx21.c
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ int __init mx21_clocks_init(unsigned long lref, unsigned long href)
clk_register_clkdev(clk[IMX21_CLK_I2C_GATE], NULL, "imx21-i2c.0");
clk_register_clkdev(clk[IMX21_CLK_OWIRE_GATE], NULL, "mxc_w1.0");

mxc_timer_init(MX21_IO_ADDRESS(MX21_GPT1_BASE_ADDR), MX21_INT_GPT1);
mxc_timer_init(MX21_GPT1_BASE_ADDR, MX21_INT_GPT1);

return 0;
}
Expand Down
2 changes: 1 addition & 1 deletion arch/arm/mach-imx/clk-imx27.c
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ int __init mx27_clocks_init(unsigned long fref)
clk_register_clkdev(clk[IMX27_CLK_EMMA_AHB_GATE], "ahb", "m2m-emmaprp.0");
clk_register_clkdev(clk[IMX27_CLK_EMMA_IPG_GATE], "ipg", "m2m-emmaprp.0");

mxc_timer_init(MX27_IO_ADDRESS(MX27_GPT1_BASE_ADDR), MX27_INT_GPT1);
mxc_timer_init(MX27_GPT1_BASE_ADDR, MX27_INT_GPT1);

return 0;
}
Expand Down
2 changes: 1 addition & 1 deletion arch/arm/mach-imx/clk-imx31.c
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ int __init mx31_clocks_init(unsigned long fref)
mx31_revision();
clk_disable_unprepare(clk[iim_gate]);

mxc_timer_init(MX31_IO_ADDRESS(MX31_GPT1_BASE_ADDR), MX31_INT_GPT);
mxc_timer_init(MX31_GPT1_BASE_ADDR, MX31_INT_GPT);

return 0;
}
Expand Down
2 changes: 1 addition & 1 deletion arch/arm/mach-imx/clk-imx35.c
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,7 @@ int __init mx35_clocks_init(void)
#ifdef CONFIG_MXC_USE_EPIT
epit_timer_init(MX35_IO_ADDRESS(MX35_EPIT1_BASE_ADDR), MX35_INT_EPIT1);
#else
mxc_timer_init(MX35_IO_ADDRESS(MX35_GPT1_BASE_ADDR), MX35_INT_GPT);
mxc_timer_init(MX35_GPT1_BASE_ADDR, MX35_INT_GPT);
#endif

return 0;
Expand Down
2 changes: 1 addition & 1 deletion arch/arm/mach-imx/common.h
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ void imx27_soc_init(void);
void imx31_soc_init(void);
void imx35_soc_init(void);
void epit_timer_init(void __iomem *base, int irq);
void mxc_timer_init(void __iomem *, int);
void mxc_timer_init(unsigned long, int);
int mx1_clocks_init(unsigned long fref);
int mx21_clocks_init(unsigned long lref, unsigned long fref);
int mx27_clocks_init(unsigned long fref);
Expand Down
5 changes: 3 additions & 2 deletions arch/arm/mach-imx/time.c
Original file line number Diff line number Diff line change
Expand Up @@ -344,12 +344,13 @@ static void __init _mxc_timer_init(int irq,
setup_irq(irq, &mxc_timer_irq);
}

void __init mxc_timer_init(void __iomem *base, int irq)
void __init mxc_timer_init(unsigned long pbase, int irq)
{
struct clk *clk_per = clk_get_sys("imx-gpt.0", "per");
struct clk *clk_ipg = clk_get_sys("imx-gpt.0", "ipg");

timer_base = base;
timer_base = ioremap(pbase, SZ_4K);
BUG_ON(!timer_base);

_mxc_timer_init(irq, clk_per, clk_ipg);
}
Expand Down

0 comments on commit 6c529c4

Please sign in to comment.