Skip to content

Commit

Permalink
drivers/platform/x86: Use kzalloc
Browse files Browse the repository at this point in the history
Use kzalloc rather than the combination of kmalloc and memset.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression x,size,flags;
statement S;
@@

-x = kmalloc(size,flags);
+x = kzalloc(size,flags);
 if (x == NULL) S
-memset(x, 0, size);
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
  • Loading branch information
Julia Lawall authored and Matthew Garrett committed May 20, 2010
1 parent 420f5f0 commit 6c75dd0
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions drivers/platform/x86/fujitsu-laptop.c
Original file line number Diff line number Diff line change
Expand Up @@ -1090,10 +1090,9 @@ static int __init fujitsu_init(void)
if (acpi_disabled)
return -ENODEV;

fujitsu = kmalloc(sizeof(struct fujitsu_t), GFP_KERNEL);
fujitsu = kzalloc(sizeof(struct fujitsu_t), GFP_KERNEL);
if (!fujitsu)
return -ENOMEM;
memset(fujitsu, 0, sizeof(struct fujitsu_t));
fujitsu->keycode1 = KEY_PROG1;
fujitsu->keycode2 = KEY_PROG2;
fujitsu->keycode3 = KEY_PROG3;
Expand Down Expand Up @@ -1150,12 +1149,11 @@ static int __init fujitsu_init(void)

/* Register hotkey driver */

fujitsu_hotkey = kmalloc(sizeof(struct fujitsu_hotkey_t), GFP_KERNEL);
fujitsu_hotkey = kzalloc(sizeof(struct fujitsu_hotkey_t), GFP_KERNEL);
if (!fujitsu_hotkey) {
ret = -ENOMEM;
goto fail_hotkey;
}
memset(fujitsu_hotkey, 0, sizeof(struct fujitsu_hotkey_t));

result = acpi_bus_register_driver(&acpi_fujitsu_hotkey_driver);
if (result < 0) {
Expand Down

0 comments on commit 6c75dd0

Please sign in to comment.