Skip to content

Commit

Permalink
ext4: fix corruption when online resizing a fs with 1K block size
Browse files Browse the repository at this point in the history
Subtracting the number of the first data block places the superblock
backups one block too early, corrupting the file system. When the block
size is larger than 1K, the first data block is 0, so the subtraction
has no effect and no corruption occurs.

Signed-off-by: Maarten ter Huurne <maarten@treewalker.org>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Reviewed-by: Jan Kara <jack@suse.cz>
CC: stable@vger.kernel.org
  • Loading branch information
Maarten ter Huurne authored and Theodore Ts'o committed Jul 1, 2013
1 parent 03b40e3 commit 6ca792e
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions fs/ext4/resize.c
Original file line number Diff line number Diff line change
Expand Up @@ -1660,12 +1660,10 @@ static int ext4_group_extend_no_check(struct super_block *sb,
err = err2;

if (!err) {
ext4_fsblk_t first_block;
first_block = ext4_group_first_block_no(sb, 0);
if (test_opt(sb, DEBUG))
printk(KERN_DEBUG "EXT4-fs: extended group to %llu "
"blocks\n", ext4_blocks_count(es));
update_backups(sb, EXT4_SB(sb)->s_sbh->b_blocknr - first_block,
update_backups(sb, EXT4_SB(sb)->s_sbh->b_blocknr,
(char *)es, sizeof(struct ext4_super_block), 0);
}
return err;
Expand Down

0 comments on commit 6ca792e

Please sign in to comment.