Skip to content

Commit

Permalink
bridge: Fix setting a flag in br_fill_ifvlaninfo_range().
Browse files Browse the repository at this point in the history
This patch fixes setting of vinfo.flags in the br_fill_ifvlaninfo_range() method. The
assignment of vinfo.flags &= ~BRIDGE_VLAN_INFO_RANGE_BEGIN has no effect and is
unneeded, as vinfo.flags value is overriden by the  immediately following
vinfo.flags = flags | BRIDGE_VLAN_INFO_RANGE_END assignement.

Signed-off-by: Rami Rosen <rami.rosen@intel.com>
Acked-by: Roopa Prabhu <roopa@cumulusnetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Rosen, Rami authored and David S. Miller committed Jul 25, 2015
1 parent a155a5d commit 6ca91c6
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions net/bridge/br_netlink.c
Original file line number Diff line number Diff line change
Expand Up @@ -164,8 +164,6 @@ static int br_fill_ifvlaninfo_range(struct sk_buff *skb, u16 vid_start,
sizeof(vinfo), &vinfo))
goto nla_put_failure;

vinfo.flags &= ~BRIDGE_VLAN_INFO_RANGE_BEGIN;

vinfo.vid = vid_end;
vinfo.flags = flags | BRIDGE_VLAN_INFO_RANGE_END;
if (nla_put(skb, IFLA_BRIDGE_VLAN_INFO,
Expand Down

0 comments on commit 6ca91c6

Please sign in to comment.