Skip to content

Commit

Permalink
net/flow: Fix potential memory leak
Browse files Browse the repository at this point in the history
While preparing net flow caches, once a fail may cause potential
memory leak , fix it.

Signed-off-by: Huajun Li <huajun.li.lee@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
huajun li authored and David S. Miller committed Oct 17, 2011
1 parent e6f8aa9 commit 6ccc3ab
Showing 1 changed file with 13 additions and 1 deletion.
14 changes: 13 additions & 1 deletion net/core/flow.c
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,7 @@ static int __init flow_cache_init(struct flow_cache *fc)

for_each_online_cpu(i) {
if (flow_cache_cpu_prepare(fc, i))
return -ENOMEM;
goto err;
}
fc->hotcpu_notifier = (struct notifier_block){
.notifier_call = flow_cache_cpu,
Expand All @@ -426,6 +426,18 @@ static int __init flow_cache_init(struct flow_cache *fc)
add_timer(&fc->rnd_timer);

return 0;

err:
for_each_possible_cpu(i) {
struct flow_cache_percpu *fcp = per_cpu_ptr(fc->percpu, i);
kfree(fcp->hash_table);
fcp->hash_table = NULL;
}

free_percpu(fc->percpu);
fc->percpu = NULL;

return -ENOMEM;
}

static int __init flow_cache_init_global(void)
Expand Down

0 comments on commit 6ccc3ab

Please sign in to comment.