Skip to content

Commit

Permalink
backlight: progear_bl - Use platform_device_register_simple()
Browse files Browse the repository at this point in the history
Use platform_device_register_simple() and also fix error
handling when platform_device_alloc() fails (progearbl_driver
is left registered).

Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Signed-off-by: Richard Purdie <rpurdie@linux.intel.com>
  • Loading branch information
Akinobu Mita authored and Richard Purdie committed Jan 8, 2009
1 parent 3bcdcc0 commit 6cd6f35
Showing 1 changed file with 8 additions and 12 deletions.
20 changes: 8 additions & 12 deletions drivers/video/backlight/progear_bl.c
Original file line number Diff line number Diff line change
Expand Up @@ -119,20 +119,16 @@ static int __init progearbl_init(void)
{
int ret = platform_driver_register(&progearbl_driver);

if (!ret) {
progearbl_device = platform_device_alloc("progear-bl", -1);
if (!progearbl_device)
return -ENOMEM;

ret = platform_device_add(progearbl_device);

if (ret) {
platform_device_put(progearbl_device);
platform_driver_unregister(&progearbl_driver);
}
if (ret)
return ret;
progearbl_device = platform_device_register_simple("progear-bl", -1,
NULL, 0);
if (IS_ERR(progearbl_device)) {
platform_driver_unregister(&progearbl_driver);
return PTR_ERR(progearbl_device);
}

return ret;
return 0;
}

static void __exit progearbl_exit(void)
Expand Down

0 comments on commit 6cd6f35

Please sign in to comment.