Skip to content

Commit

Permalink
[PATCH] [libata] Kill 'count' var in ata_device_add()
Browse files Browse the repository at this point in the history
Eliminate redundant loop variable 'count'

Signed-off-by: Jeff Garzik <jeff@garzik.org>
Signed-off-by: Tejun Heo <htejun@gmail.com>
  • Loading branch information
Jeff Garzik authored and Tejun Heo committed Aug 10, 2006
1 parent 996139f commit 6d0500d
Showing 1 changed file with 7 additions and 13 deletions.
20 changes: 7 additions & 13 deletions drivers/scsi/libata-core.c
Original file line number Diff line number Diff line change
Expand Up @@ -5403,7 +5403,7 @@ void ata_host_set_init(struct ata_host_set *host_set,
*/
int ata_device_add(const struct ata_probe_ent *ent)
{
unsigned int count = 0, i;
unsigned int i;
struct device *dev = ent->dev;
struct ata_host_set *host_set;
int rc;
Expand All @@ -5422,7 +5422,7 @@ int ata_device_add(const struct ata_probe_ent *ent)
host_set->private_data = ent->private_data;

/* register each port bound to this device */
for (i = 0; i < ent->n_ports; i++) {
for (i = 0; i < host_set->n_ports; i++) {
struct ata_port *ap;
unsigned long xfer_mode_mask;

Expand All @@ -5448,12 +5448,8 @@ int ata_device_add(const struct ata_probe_ent *ent)
ata_chk_status(ap);
host_set->ops->irq_clear(ap);
ata_eh_freeze_port(ap); /* freeze port before requesting IRQ */
count++;
}

if (!count)
goto err_free_ret;

/* obtain irq, that is shared between channels */
rc = request_irq(ent->irq, ent->port_ops->irq_handler, ent->irq_flags,
DRV_NAME, host_set);
Expand All @@ -5465,13 +5461,11 @@ int ata_device_add(const struct ata_probe_ent *ent)

/* perform each probe synchronously */
DPRINTK("probe begin\n");
for (i = 0; i < count; i++) {
struct ata_port *ap;
for (i = 0; i < host_set->n_ports; i++) {
struct ata_port *ap = host_set->ports[i];
u32 scontrol;
int rc;

ap = host_set->ports[i];

/* init sata_spd_limit to the current value */
if (sata_scr_read(ap, SCR_CONTROL, &scontrol) == 0) {
int spd = (scontrol >> 4) & 0xf;
Expand Down Expand Up @@ -5527,7 +5521,7 @@ int ata_device_add(const struct ata_probe_ent *ent)

/* probes are done, now scan each port's disk(s) */
DPRINTK("host probe begin\n");
for (i = 0; i < count; i++) {
for (i = 0; i < host_set->n_ports; i++) {
struct ata_port *ap = host_set->ports[i];

ata_scsi_scan_host(ap);
Expand All @@ -5539,14 +5533,14 @@ int ata_device_add(const struct ata_probe_ent *ent)
return ent->n_ports; /* success */

err_out:
for (i = 0; i < count; i++) {
for (i = 0; i < host_set->n_ports; i++) {
struct ata_port *ap = host_set->ports[i];
if (ap) {
ap->ops->port_stop(ap);
scsi_host_put(ap->host);
}
}
err_free_ret:

kfree(host_set);
VPRINTK("EXIT, returning 0\n");
return 0;
Expand Down

0 comments on commit 6d0500d

Please sign in to comment.