Skip to content

Commit

Permalink
ARM/locomo: Consolidate chained IRQ handler install/remove
Browse files Browse the repository at this point in the history
Chained irq handlers usually set up handler data as well. We now have
a function to set both under irq_desc->lock. Replace the two calls
with one.

Search and conversion was done with coccinelle.

Reported-by: Russell King <rmk+kernel@arm.linux.org.uk>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: Russell King <linux+kernel@arm.linux.org.uk>
Cc: linux-arm-kernel@lists.infradead.org
  • Loading branch information
Thomas Gleixner committed Jul 13, 2015
1 parent 206287c commit 6d0786a
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions arch/arm/common/locomo.c
Original file line number Diff line number Diff line change
Expand Up @@ -475,8 +475,7 @@ static void __locomo_remove(struct locomo *lchip)
device_for_each_child(lchip->dev, NULL, locomo_remove_child);

if (lchip->irq != NO_IRQ) {
irq_set_chained_handler(lchip->irq, NULL);
irq_set_handler_data(lchip->irq, NULL);
irq_set_chained_handler_and_data(lchip->irq, NULL, NULL);
}

iounmap(lchip->base);
Expand Down

0 comments on commit 6d0786a

Please sign in to comment.