---

yaml --- r: 19661 b: refs/heads/master c: 7d95c8f h: refs/heads/master i: 19659: cbec939 v: v3
git-mirror · Feb 3, 2006 · 6d387f6 · 6d387f6
1 parent ec00a65
commit 6d387f6
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/[refs] b/[refs]
@@ -1,2 +1,2 @@
 ---
-refs/heads/master: 8b3e09e19932835fb77c63aaf3b1af6117e78871
+refs/heads/master: 7d95c8f27d9be65bf160f1edaf653d33dfceb58c
diff --git a/trunk/fs/fcntl.c b/trunk/fs/fcntl.c
@@ -208,8 +208,11 @@ static int setfl(int fd, struct file * filp, unsigned long arg)
 	struct inode * inode = filp->f_dentry->d_inode;
 	int error = 0;
 
-	/* O_APPEND cannot be cleared if the file is marked as append-only */
-	if (!(arg & O_APPEND) && IS_APPEND(inode))
+	/*
+	 * O_APPEND cannot be cleared if the file is marked as append-only
+	 * and the file is open for write.
+	 */
+	if (((arg ^ filp->f_flags) & O_APPEND) && IS_APPEND(inode))
 		return -EPERM;
 
 	/* O_NOATIME can only be set by the owner or superuser */