Skip to content

Commit

Permalink
net: phy: spi_ks8995: remove unnecessary spi_set_drvdata()
Browse files Browse the repository at this point in the history
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Jingoo Han authored and David S. Miller committed Dec 11, 2013
1 parent 5535ec7 commit 6d4bebe
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions drivers/net/phy/spi_ks8995.c
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,6 @@ static int ks8995_probe(struct spi_device *spi)
return 0;

err_drvdata:
spi_set_drvdata(spi, NULL);
kfree(ks);
return err;
}
Expand All @@ -337,7 +336,6 @@ static int ks8995_remove(struct spi_device *spi)
ks8995 = spi_get_drvdata(spi);
sysfs_remove_bin_file(&spi->dev.kobj, &ks8995_registers_attr);

spi_set_drvdata(spi, NULL);
kfree(ks8995);

return 0;
Expand Down

0 comments on commit 6d4bebe

Please sign in to comment.