Skip to content

Commit

Permalink
s390: don't use flush_scheduled_work()
Browse files Browse the repository at this point in the history
flush_scheduled_work() is deprecated and scheduled to be removed.

* tape_3590: Create and use tape_3590_wq instead of the system_wq.

* tape_block: Directly flush requeue_task on cleanup instead of using
  flush_scheduled_work().

Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: linux390@de.ibm.com
Cc: linux-s390@vger.kernel.org
  • Loading branch information
Tejun Heo committed Dec 24, 2010
1 parent 9db8995 commit 6dca467
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 6 deletions.
18 changes: 13 additions & 5 deletions drivers/s390/char/tape_3590.c
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@
#include "tape_std.h"
#include "tape_3590.h"

static struct workqueue_struct *tape_3590_wq;

/*
* Pointer to debug area.
*/
Expand Down Expand Up @@ -613,7 +615,7 @@ tape_3590_schedule_work(struct tape_device *device, enum tape_op op)
p->device = tape_get_device(device);
p->op = op;

schedule_work(&p->work);
queue_work(tape_3590_wq, &p->work);
return 0;
}

Expand Down Expand Up @@ -1629,7 +1631,7 @@ tape_3590_setup_device(struct tape_device *device)
static void
tape_3590_cleanup_device(struct tape_device *device)
{
flush_scheduled_work();
flush_workqueue(tape_3590_wq);
tape_std_unassign(device);

kfree(device->discdata);
Expand Down Expand Up @@ -1733,11 +1735,17 @@ tape_3590_init(void)
#endif

DBF_EVENT(3, "3590 init\n");

tape_3590_wq = alloc_workqueue("tape_3590", 0, 0);
if (!tape_3590_wq)
return -ENOMEM;

/* Register driver for 3590 tapes. */
rc = ccw_driver_register(&tape_3590_driver);
if (rc)
if (rc) {
destroy_workqueue(tape_3590_wq);
DBF_EVENT(3, "3590 init failed\n");
else
} else
DBF_EVENT(3, "3590 registered\n");
return rc;
}
Expand All @@ -1746,7 +1754,7 @@ static void
tape_3590_exit(void)
{
ccw_driver_unregister(&tape_3590_driver);

destroy_workqueue(tape_3590_wq);
debug_unregister(TAPE_DBF_AREA);
}

Expand Down
2 changes: 1 addition & 1 deletion drivers/s390/char/tape_block.c
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,7 @@ tapeblock_setup_device(struct tape_device * device)
void
tapeblock_cleanup_device(struct tape_device *device)
{
flush_scheduled_work();
flush_work_sync(&device->blk_data.requeue_task);
tape_put_device(device);

if (!device->blk_data.disk) {
Expand Down

0 comments on commit 6dca467

Please sign in to comment.