Skip to content

Commit

Permalink
gpio/pca953x: Fix warning of enabled interrupts in handler
Browse files Browse the repository at this point in the history
When using nested threaded irqs, use handle_nested_irq(). This function
does not call the chip handler, so no handler is set.

Signed-off-by: David Jander <david@protonic.nl>
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
  • Loading branch information
David Jander authored and Grant Likely committed Jun 8, 2011
1 parent 17e8b42 commit 6dd599f
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions drivers/gpio/gpio-pca953x.c
Original file line number Diff line number Diff line change
Expand Up @@ -437,7 +437,7 @@ static irqreturn_t pca953x_irq_handler(int irq, void *devid)

do {
level = __ffs(pending);
generic_handle_irq(level + chip->irq_base);
handle_nested_irq(level + chip->irq_base);

pending &= ~(1 << level);
} while (pending);
Expand Down Expand Up @@ -485,8 +485,8 @@ static int pca953x_irq_setup(struct pca953x_chip *chip,

irq_clear_status_flags(irq, IRQ_NOREQUEST);
irq_set_chip_data(irq, chip);
irq_set_chip_and_handler(irq, &pca953x_irq_chip,
handle_simple_irq);
irq_set_chip(irq, &pca953x_irq_chip);
irq_set_nested_thread(irq, true);
#ifdef CONFIG_ARM
set_irq_flags(irq, IRQF_VALID);
#else
Expand Down

0 comments on commit 6dd599f

Please sign in to comment.