Skip to content

Commit

Permalink
nfsd: Drop reference in expkey_parse error cases
Browse files Browse the repository at this point in the history
Drop reference to export key on error. Compile tested.

Signed-off-by: Krishna Kumar <krkumar2@in.ibm.com>
Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
  • Loading branch information
Krishna Kumar authored and J. Bruce Fields committed Oct 22, 2008
1 parent 6c6a426 commit 6dfcde9
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions fs/nfsd/export.c
Original file line number Diff line number Diff line change
Expand Up @@ -151,8 +151,10 @@ static int expkey_parse(struct cache_detail *cd, char *mesg, int mlen)

/* now we want a pathname, or empty meaning NEGATIVE */
err = -EINVAL;
if ((len=qword_get(&mesg, buf, PAGE_SIZE)) < 0)
if ((len=qword_get(&mesg, buf, PAGE_SIZE)) < 0) {
cache_put(&ek->h, &svc_expkey_cache);
goto out;
}
dprintk("Path seems to be <%s>\n", buf);
err = 0;
if (len == 0) {
Expand All @@ -164,8 +166,10 @@ static int expkey_parse(struct cache_detail *cd, char *mesg, int mlen)
} else {
struct nameidata nd;
err = path_lookup(buf, 0, &nd);
if (err)
if (err) {
cache_put(&ek->h, &svc_expkey_cache);
goto out;
}

dprintk("Found the path %s\n", buf);
key.ek_path = nd.path;
Expand Down

0 comments on commit 6dfcde9

Please sign in to comment.