Skip to content

Commit

Permalink
perf tools: Save partial non-overlapping map
Browse files Browse the repository at this point in the history
The librarization of the thread helpers between annotate and
report lost some perf report specifics.

thread__insert_map() had its most uptodate version in perf
report which cared about partial map overlapping. In case of
overlap between two maps, perf annotate's version removes the
whole old map without considering if it partially or
absolutely overlaps the new map.

We exported the odd version, change it by using the perf
report version.

Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Mike Galbraith <efault@gmx.de>
LKML-Reference: <1250607843-7395-1-git-send-email-fweisbec@gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
Frederic Weisbecker authored and Ingo Molnar committed Aug 18, 2009
1 parent 4273b00 commit 6e08643
Showing 1 changed file with 22 additions and 3 deletions.
25 changes: 22 additions & 3 deletions tools/perf/util/thread.c
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
#include <string.h>
#include "thread.h"
#include "util.h"
#include "debug.h"

static struct thread *thread__new(pid_t pid)
{
Expand Down Expand Up @@ -85,9 +86,27 @@ void thread__insert_map(struct thread *self, struct map *map)

list_for_each_entry_safe(pos, tmp, &self->maps, node) {
if (map__overlap(pos, map)) {
list_del_init(&pos->node);
/* XXX leaks dsos */
free(pos);
if (verbose >= 2) {
printf("overlapping maps:\n");
map__fprintf(map, stdout);
map__fprintf(pos, stdout);
}

if (map->start <= pos->start && map->end > pos->start)
pos->start = map->end;

if (map->end >= pos->end && map->start < pos->end)
pos->end = map->start;

if (verbose >= 2) {
printf("after collision:\n");
map__fprintf(pos, stdout);
}

if (pos->start >= pos->end) {
list_del_init(&pos->node);
free(pos);
}
}
}

Expand Down

0 comments on commit 6e08643

Please sign in to comment.