Skip to content

Commit

Permalink
USB-BKL: Remove lock_kernel in usbfs update_sb()
Browse files Browse the repository at this point in the history
The code this is attempting to lock against does not use the BKL,
so it's not needed.

Most likely this code is still broken/racy (Al Viro also thinks so),
but removing the BKL should not make it worse than before.

Signed-off-by: Andi Kleen <ak@linux.intel.com>
Cc: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Andi Kleen authored and Greg Kroah-Hartman committed Aug 10, 2010
1 parent 16f76a7 commit 6e12ea4
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions drivers/usb/core/inode.c
Original file line number Diff line number Diff line change
Expand Up @@ -265,13 +265,9 @@ static int remount(struct super_block *sb, int *flags, char *data)
return -EINVAL;
}

lock_kernel();

if (usbfs_mount && usbfs_mount->mnt_sb)
update_sb(usbfs_mount->mnt_sb);

unlock_kernel();

return 0;
}

Expand Down

0 comments on commit 6e12ea4

Please sign in to comment.