Skip to content

Commit

Permalink
x86, boot: Rename get_flags() and check_flags() to *_cpuflags()
Browse files Browse the repository at this point in the history
When a function is used in more than one file it may not be possible
to immediately tell from context what the intended meaning is.  As
such, it is more important that the naming be self-evident.  Thus,
change get_flags() to get_cpuflags().

For consistency, change check_flags() to check_cpuflags() even though
it is only used in cpucheck.c.

Link: http://lkml.kernel.org/r/1381450698-28710-2-git-send-email-keescook@chromium.org
Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
  • Loading branch information
H. Peter Anvin committed Oct 13, 2013
1 parent 6145cfe commit 6e6a493
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 10 deletions.
2 changes: 1 addition & 1 deletion arch/x86/boot/compressed/cpuflags.c
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

bool has_cpuflag(int flag)
{
get_flags();
get_cpuflags();

return test_bit(flag, cpu.flags);
}
Expand Down
14 changes: 7 additions & 7 deletions arch/x86/boot/cpucheck.c
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ static int is_transmeta(void)
}

/* Returns a bitmask of which words we have error bits in */
static int check_flags(void)
static int check_cpuflags(void)
{
u32 err;
int i;
Expand Down Expand Up @@ -101,8 +101,8 @@ int check_cpu(int *cpu_level_ptr, int *req_level_ptr, u32 **err_flags_ptr)
if (has_eflag(X86_EFLAGS_AC))
cpu.level = 4;

get_flags();
err = check_flags();
get_cpuflags();
err = check_cpuflags();

if (test_bit(X86_FEATURE_LM, cpu.flags))
cpu.level = 64;
Expand All @@ -121,8 +121,8 @@ int check_cpu(int *cpu_level_ptr, int *req_level_ptr, u32 **err_flags_ptr)
eax &= ~(1 << 15);
asm("wrmsr" : : "a" (eax), "d" (edx), "c" (ecx));

get_flags(); /* Make sure it really did something */
err = check_flags();
get_cpuflags(); /* Make sure it really did something */
err = check_cpuflags();
} else if (err == 0x01 &&
!(err_flags[0] & ~(1 << X86_FEATURE_CX8)) &&
is_centaur() && cpu.model >= 6) {
Expand All @@ -137,7 +137,7 @@ int check_cpu(int *cpu_level_ptr, int *req_level_ptr, u32 **err_flags_ptr)
asm("wrmsr" : : "a" (eax), "d" (edx), "c" (ecx));

set_bit(X86_FEATURE_CX8, cpu.flags);
err = check_flags();
err = check_cpuflags();
} else if (err == 0x01 && is_transmeta()) {
/* Transmeta might have masked feature bits in word 0 */

Expand All @@ -152,7 +152,7 @@ int check_cpu(int *cpu_level_ptr, int *req_level_ptr, u32 **err_flags_ptr)
: : "ecx", "ebx");
asm("wrmsr" : : "a" (eax), "d" (edx), "c" (ecx));

err = check_flags();
err = check_cpuflags();
}

if (err_flags_ptr)
Expand Down
2 changes: 1 addition & 1 deletion arch/x86/boot/cpuflags.c
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ static inline void cpuid(u32 id, u32 *a, u32 *b, u32 *c, u32 *d)
);
}

void get_flags(void)
void get_cpuflags(void)
{
u32 max_intel_level, max_amd_level;
u32 tfms;
Expand Down
2 changes: 1 addition & 1 deletion arch/x86/boot/cpuflags.h
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,6 @@ extern struct cpu_features cpu;
extern u32 cpu_vendor[3];

int has_eflag(unsigned long mask);
void get_flags(void);
void get_cpuflags(void);

#endif

0 comments on commit 6e6a493

Please sign in to comment.