Skip to content

Commit

Permalink
[media] drivers/media/rc/redrat3.c: fix error return code
Browse files Browse the repository at this point in the history
Convert a nonnegative error return code to a negative one, as returned
elsewhere in the function.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
 { ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
    when != &ret
*if(...)
{
  ... when != ret = e2
      when forall
 return ret;
}
// </smpl>

Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  • Loading branch information
Peter Senna Tschudin authored and Mauro Carvalho Chehab committed Sep 23, 2012
1 parent 24e527a commit 6ea7cf7
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions drivers/media/rc/redrat3.c
Original file line number Diff line number Diff line change
Expand Up @@ -1217,9 +1217,10 @@ static int __devinit redrat3_dev_probe(struct usb_interface *intf,
rr3->carrier = 38000;

rr3->rc = redrat3_init_rc_dev(rr3);
if (!rr3->rc)
if (!rr3->rc) {
retval = -ENOMEM;
goto error;

}
setup_timer(&rr3->rx_timeout, redrat3_rx_timeout, (unsigned long)rr3);

/* we can register the device now, as it is ready */
Expand Down

0 comments on commit 6ea7cf7

Please sign in to comment.