Skip to content

Commit

Permalink
Input: xpad - don't use GFP_ATOMIC
Browse files Browse the repository at this point in the history
GFP_ATOMIC should not be used when GFP_KERNEL can be used.

Signed-off-by: Oliver Neukum <oneukum@suse.de>
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
  • Loading branch information
Oliver Neukum authored and Dmitry Torokhov committed Apr 3, 2008
1 parent 99de091 commit 6eae9b0
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/input/joystick/xpad.c
Original file line number Diff line number Diff line change
Expand Up @@ -497,7 +497,7 @@ static int xpad_init_output(struct usb_interface *intf, struct usb_xpad *xpad)
return 0;

xpad->odata = usb_buffer_alloc(xpad->udev, XPAD_PKT_LEN,
GFP_ATOMIC, &xpad->odata_dma );
GFP_KERNEL, &xpad->odata_dma);
if (!xpad->odata)
goto fail1;

Expand Down Expand Up @@ -729,7 +729,7 @@ static int xpad_probe(struct usb_interface *intf, const struct usb_device_id *id
goto fail1;

xpad->idata = usb_buffer_alloc(udev, XPAD_PKT_LEN,
GFP_ATOMIC, &xpad->idata_dma);
GFP_KERNEL, &xpad->idata_dma);
if (!xpad->idata)
goto fail1;

Expand Down

0 comments on commit 6eae9b0

Please sign in to comment.