Skip to content

Commit

Permalink
mac80211: do not requeue scan work when not needed
Browse files Browse the repository at this point in the history
When performing hw scan and not abort it, __ieee80211_scan_completed()
is currently called from scan work, so does not need to reschedule work
to call drv_hw_scan().

Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
Acked-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
  • Loading branch information
Stanislaw Gruszka authored and John W. Linville committed Oct 6, 2010
1 parent 4136c42 commit 6eb11a9
Showing 1 changed file with 3 additions and 12 deletions.
15 changes: 3 additions & 12 deletions net/mac80211/scan.c
Original file line number Diff line number Diff line change
Expand Up @@ -269,9 +269,9 @@ static bool __ieee80211_scan_completed(struct ieee80211_hw *hw, bool aborted,
return false;

if (was_hw_scan && !aborted && ieee80211_prep_hw_scan(local)) {
ieee80211_queue_delayed_work(&local->hw,
&local->scan_work, 0);
return false;
int rc = drv_hw_scan(local, local->scan_sdata, local->hw_scan_req);
if (rc == 0)
return false;
}

kfree(local->hw_scan_req);
Expand Down Expand Up @@ -656,15 +656,6 @@ void ieee80211_scan_work(struct work_struct *work)
if (!sdata || !local->scan_req)
goto out;

if (local->hw_scan_req) {
int rc = drv_hw_scan(local, sdata, local->hw_scan_req);
if (rc) {
aborted = true;
goto out_complete;
} else
goto out;
}

if (local->scan_req && !local->scanning) {
struct cfg80211_scan_request *req = local->scan_req;
int rc;
Expand Down

0 comments on commit 6eb11a9

Please sign in to comment.