Skip to content

Commit

Permalink
mtd: autcpu12-nvram: drop frees of devm_ alloc'd data
Browse files Browse the repository at this point in the history
devm free functions should not have to be explicitly used.

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
  • Loading branch information
Julia Lawall authored and David Woodhouse committed Sep 29, 2012
1 parent fac0077 commit 6f12f59
Showing 1 changed file with 4 additions and 14 deletions.
18 changes: 4 additions & 14 deletions drivers/mtd/maps/autcpu12-nvram.c
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ static int __devinit autcpu12_nvram_probe(struct platform_device *pdev)
map_word tmp, save0, save1;
struct resource *res;
struct autcpu12_nvram_priv *priv;
int err;

priv = devm_kzalloc(&pdev->dev,
sizeof(struct autcpu12_nvram_priv), GFP_KERNEL);
Expand All @@ -50,8 +49,7 @@ static int __devinit autcpu12_nvram_probe(struct platform_device *pdev)
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
if (!res) {
dev_err(&pdev->dev, "failed to get memory resource\n");
err = -ENOENT;
goto out;
return -ENOENT;
}

priv->map.bankwidth = 4;
Expand All @@ -61,8 +59,7 @@ static int __devinit autcpu12_nvram_probe(struct platform_device *pdev)
strcpy((char *)priv->map.name, res->name);
if (!priv->map.virt) {
dev_err(&pdev->dev, "failed to remap mem resource\n");
err = -EBUSY;
goto out;
return -EBUSY;
}

simple_map_init(&priv->map);
Expand Down Expand Up @@ -90,8 +87,7 @@ static int __devinit autcpu12_nvram_probe(struct platform_device *pdev)
priv->mtd = do_map_probe("map_ram", &priv->map);
if (!priv->mtd) {
dev_err(&pdev->dev, "probing failed\n");
err = -ENXIO;
goto out;
return -ENXIO;
}

priv->mtd->owner = THIS_MODULE;
Expand All @@ -106,12 +102,7 @@ static int __devinit autcpu12_nvram_probe(struct platform_device *pdev)

map_destroy(priv->mtd);
dev_err(&pdev->dev, "NV-RAM device addition failed\n");
err = -ENOMEM;

out:
devm_kfree(&pdev->dev, priv);

return err;
return -ENOMEM;
}

static int __devexit autcpu12_nvram_remove(struct platform_device *pdev)
Expand All @@ -120,7 +111,6 @@ static int __devexit autcpu12_nvram_remove(struct platform_device *pdev)

mtd_device_unregister(priv->mtd);
map_destroy(priv->mtd);
devm_kfree(&pdev->dev, priv);

return 0;
}
Expand Down

0 comments on commit 6f12f59

Please sign in to comment.