Skip to content

Commit

Permalink
ceph: fix theoretically possible double-put on connection
Browse files Browse the repository at this point in the history
This would only trigger if we bailed out before resetting r_con_filling_msg
because the server reply was corrupt (oversized).

Signed-off-by: Sage Weil <sage@newdream.net>
  • Loading branch information
Sage Weil committed May 17, 2010
1 parent c770807 commit 6f46cb2
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions fs/ceph/osd_client.c
Original file line number Diff line number Diff line change
Expand Up @@ -1386,6 +1386,7 @@ static struct ceph_msg *get_reply(struct ceph_connection *con,
req->r_reply, req->r_con_filling_msg);
ceph_con_revoke_message(req->r_con_filling_msg, req->r_reply);
ceph_con_put(req->r_con_filling_msg);
req->r_con_filling_msg = NULL;
}

if (front > req->r_reply->front.iov_len) {
Expand Down

0 comments on commit 6f46cb2

Please sign in to comment.