Skip to content

Commit

Permalink
ALSA: Replace DEFINE_PCI_DEVICE_TABLE macro use
Browse files Browse the repository at this point in the history
We should prefer `const struct pci_device_id` over
`DEFINE_PCI_DEVICE_TABLE` to meet kernel coding style guidelines.
This issue was reported by checkpatch.

A simplified version of the semantic patch that makes this change is as
follows (http://coccinelle.lip6.fr/):

// <smpl>

@@
identifier i;
declarer name DEFINE_PCI_DEVICE_TABLE;
initializer z;
@@

- DEFINE_PCI_DEVICE_TABLE(i)
+ const struct pci_device_id i[]
= z;

// </smpl>

It has been tested by compilation.

Signed-off-by: Benoit Taine <benoit.taine@lip6.fr>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
  • Loading branch information
Benoit Taine authored and Takashi Iwai committed May 22, 2014
1 parent 13fd08a commit 6f51f6c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion sound/pci/hda/hda_intel.c
Original file line number Diff line number Diff line change
Expand Up @@ -1724,7 +1724,7 @@ static void azx_remove(struct pci_dev *pci)
}

/* PCI IDs */
static DEFINE_PCI_DEVICE_TABLE(azx_ids) = {
static const struct pci_device_id azx_ids[] = {
/* CPT */
{ PCI_DEVICE(0x8086, 0x1c20),
.driver_data = AZX_DRIVER_PCH | AZX_DCAPS_INTEL_PCH_NOPM },
Expand Down

0 comments on commit 6f51f6c

Please sign in to comment.