Skip to content

Commit

Permalink
PCI: ROUND_UP macro cleanup in drivers/pci
Browse files Browse the repository at this point in the history
ROUND_UP macro cleanup, use ALIGN where ever appropriate

Signed-off-by: Milind Arun Choudhary <milindchoudhary@gmail.com>
Acked-by: Scott Murray <scottm@somanetworks.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Milind Arun Choudhary authored and Greg Kroah-Hartman committed Jul 11, 2007
1 parent caa5171 commit 6f6f8c2
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 7 deletions.
2 changes: 0 additions & 2 deletions drivers/pci/hotplug/cpci_hotplug_pci.c
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,6 @@ extern int cpci_debug;
#define info(format, arg...) printk(KERN_INFO "%s: " format "\n", MY_NAME , ## arg)
#define warn(format, arg...) printk(KERN_WARNING "%s: " format "\n", MY_NAME , ## arg)

#define ROUND_UP(x, a) (((x) + (a) - 1) & ~((a) - 1))


u8 cpci_get_attention_status(struct slot* slot)
{
Expand Down
8 changes: 3 additions & 5 deletions drivers/pci/setup-bus.c
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,6 @@
#define DBG(x...)
#endif

#define ROUND_UP(x, a) (((x) + (a) - 1) & ~((a) - 1))

static void pbus_assign_resources_sorted(struct pci_bus *bus)
{
struct pci_dev *dev;
Expand Down Expand Up @@ -310,7 +308,7 @@ static void pbus_size_io(struct pci_bus *bus)
#if defined(CONFIG_ISA) || defined(CONFIG_EISA)
size = (size & 0xff) + ((size & ~0xffUL) << 2);
#endif
size = ROUND_UP(size + size1, 4096);
size = ALIGN(size + size1, 4096);
if (!size) {
b_res->flags = 0;
return;
Expand Down Expand Up @@ -378,11 +376,11 @@ static int pbus_size_mem(struct pci_bus *bus, unsigned long mask, unsigned long

if (!align)
min_align = align1;
else if (ROUND_UP(align + min_align, min_align) < align1)
else if (ALIGN(align + min_align, min_align) < align1)
min_align = align1 >> 1;
align += aligns[order];
}
size = ROUND_UP(size, min_align);
size = ALIGN(size, min_align);
if (!size) {
b_res->flags = 0;
return 1;
Expand Down

0 comments on commit 6f6f8c2

Please sign in to comment.