Skip to content

Commit

Permalink
Staging: sep: clean up a couple of spots missed in pass one
Browse files Browse the repository at this point in the history
Another copy_user case and some formatting of dbg

Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Alan Cox authored and Greg Kroah-Hartman committed Nov 29, 2010
1 parent 2bb3af5 commit 6f89be9
Showing 1 changed file with 5 additions and 11 deletions.
16 changes: 5 additions & 11 deletions drivers/staging/sep/sep_driver.c
Original file line number Diff line number Diff line change
Expand Up @@ -1037,8 +1037,6 @@ static int sep_allocate_data_pool_memory_handler(struct sep_device *sep,
sizeof(struct alloc_struct));
if (error) {
error = -EFAULT;
dev_warn(&sep->pdev->dev,
"allocate data pool copy to user error\n");
goto end_function;
}

Expand Down Expand Up @@ -1083,13 +1081,10 @@ static int sep_lock_kernel_pages(struct sep_device *sep,
/* Map array */
struct sep_dma_map *map_array;

dev_dbg(&sep->pdev->dev,
"sep_lock_kernel_pages start\n");

dev_dbg(&sep->pdev->dev,
"kernel_virt_addr is %08x\n", kernel_virt_addr);
dev_dbg(&sep->pdev->dev,
"data_size is %x\n", data_size);
dev_dbg(&sep->pdev->dev, "sep_lock_kernel_pages start\n");
dev_dbg(&sep->pdev->dev, "kernel_virt_addr is %08x\n",
kernel_virt_addr);
dev_dbg(&sep->pdev->dev, "data_size is %x\n", data_size);

lli_array = kmalloc(sizeof(struct sep_lli_entry), GFP_ATOMIC);
if (!lli_array) {
Expand Down Expand Up @@ -1182,8 +1177,7 @@ static int sep_lock_user_pages(struct sep_device *sep,
/* Direction of the DMA mapping for locked pages */
enum dma_data_direction dir;

dev_dbg(&sep->pdev->dev,
"sep_lock_user_pages start\n");
dev_dbg(&sep->pdev->dev, "sep_lock_user_pages start\n");

/* Set start and end pages and num pages */
end_page = (app_virt_addr + data_size - 1) >> PAGE_SHIFT;
Expand Down

0 comments on commit 6f89be9

Please sign in to comment.