Skip to content

Commit

Permalink
[media] gspca_pac7302: correct register documentation
Browse files Browse the repository at this point in the history
R,G,B balance registers are 0x01-0x03 instead of 0x02-0x04,
which lead to the wrong conclusion that values are inverted.
Exposure is controlled via page 3 registers and this is already documented.
Also fix a whitespace issue.

Signed-off-by: Frank Schäfer <fschaefer.oss@googlemail.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  • Loading branch information
Frank Schäfer authored and Mauro Carvalho Chehab committed Nov 21, 2012
1 parent 2902fb7 commit 6f9b331
Showing 1 changed file with 5 additions and 6 deletions.
11 changes: 5 additions & 6 deletions drivers/media/usb/gspca/pac7302.c
Original file line number Diff line number Diff line change
Expand Up @@ -29,14 +29,13 @@
* Register page 0:
*
* Address Description
* 0x02 Red balance control
* 0x03 Green balance control
* 0x04 Blue balance control
* Valus are inverted (0=max, 255=min).
* 0x01 Red balance control
* 0x02 Green balance control
* 0x03 Blue balance control
* The Windows driver uses a quadratic approach to map
* the settable values (0-200) on register values:
* min=0x80, default=0x40, max=0x20
* 0x0f-0x20 Colors, saturation and exposure control
* min=0x20, default=0x40, max=0x80
* 0x0f-0x20 Color and saturation control
* 0xa2-0xab Brightness, contrast and gamma control
* 0xb6 Sharpness control (bits 0-4)
*
Expand Down

0 comments on commit 6f9b331

Please sign in to comment.