Skip to content

Commit

Permalink
firewire: ohci: dump_stack() for PHY regs read/write failures
Browse files Browse the repository at this point in the history
A stack trace is an invaluable tool in determining the basis
and cause of PHY regs read/write failures.

Include PHY reg addr (and value for writes) in the diagnostic.

[Stefan R:  changed whitespace]

Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
  • Loading branch information
Peter Hurley authored and Stefan Richter committed Apr 30, 2013
1 parent 6767213 commit 6fe9efb
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions drivers/firewire/ohci.c
Original file line number Diff line number Diff line change
Expand Up @@ -572,7 +572,8 @@ static int read_phy_reg(struct fw_ohci *ohci, int addr)
if (i >= 3)
msleep(1);
}
ohci_err(ohci, "failed to read phy reg\n");
ohci_err(ohci, "failed to read phy reg %d\n", addr);
dump_stack();

return -EBUSY;
}
Expand All @@ -594,7 +595,8 @@ static int write_phy_reg(const struct fw_ohci *ohci, int addr, u32 val)
if (i >= 3)
msleep(1);
}
ohci_err(ohci, "failed to write phy reg\n");
ohci_err(ohci, "failed to write phy reg %d, val %u\n", addr, val);
dump_stack();

return -EBUSY;
}
Expand Down

0 comments on commit 6fe9efb

Please sign in to comment.