Skip to content

Commit

Permalink
[PATCH] spufs: fix sparse warnings
Browse files Browse the repository at this point in the history
One local variable is missing an __iomem modifier,
in another place, we pass a completely unused argument
with a missing __user modifier.

Signed-off-by: Arnd Bergmann <arndb@de.ibm.com>
Signed-off-by: Paul Mackerras <paulus@samba.org>
  • Loading branch information
Arnd Bergmann authored and Paul Mackerras committed Jan 9, 2006
1 parent f0831ac commit 6ff730c
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 6 deletions.
2 changes: 1 addition & 1 deletion arch/powerpc/platforms/cell/spu_base.c
Original file line number Diff line number Diff line change
Expand Up @@ -357,7 +357,7 @@ static void spu_init_channels(struct spu *spu)
{ 0x17, 1, }, { 0x18, 0, }, { 0x19, 0, }, { 0x1b, 0, },
{ 0x1c, 1, }, { 0x1d, 0, }, { 0x1e, 1, },
};
struct spu_priv2 *priv2;
struct spu_priv2 __iomem *priv2;
int i;

priv2 = spu->priv2;
Expand Down
5 changes: 2 additions & 3 deletions arch/powerpc/platforms/cell/spufs/inode.c
Original file line number Diff line number Diff line change
Expand Up @@ -293,9 +293,8 @@ static int spufs_context_open(struct dentry *dentry, struct vfsmount *mnt)

static struct file_system_type spufs_type;

long
spufs_create_thread(struct nameidata *nd, const char *name,
unsigned int flags, mode_t mode)
long spufs_create_thread(struct nameidata *nd,
unsigned int flags, mode_t mode)
{
struct dentry *dentry;
int ret;
Expand Down
2 changes: 1 addition & 1 deletion arch/powerpc/platforms/cell/spufs/spufs.h
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ extern struct tree_descr spufs_dir_contents[];
/* system call implementation */
long spufs_run_spu(struct file *file,
struct spu_context *ctx, u32 *npc, u32 *status);
long spufs_create_thread(struct nameidata *nd, const char *name,
long spufs_create_thread(struct nameidata *nd,
unsigned int flags, mode_t mode);
extern struct file_operations spufs_context_fops;

Expand Down
2 changes: 1 addition & 1 deletion arch/powerpc/platforms/cell/spufs/syscalls.c
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ asmlinkage long sys_spu_create(const char __user *pathname,
ret = path_lookup(tmp, LOOKUP_PARENT|
LOOKUP_OPEN|LOOKUP_CREATE, &nd);
if (!ret) {
ret = spufs_create_thread(&nd, pathname, flags, mode);
ret = spufs_create_thread(&nd, flags, mode);
path_release(&nd);
}
putname(tmp);
Expand Down

0 comments on commit 6ff730c

Please sign in to comment.