Skip to content

Commit

Permalink
x86/nmi: Fix the type of the nmiaction.flags field
Browse files Browse the repository at this point in the history
This patch changes the type of the struct nmiaction flags field
to unsigned long from unsigned int. All the usages of the flags
field are unsigned long already. There is only one flag used
currently, NMI_FLAG_FIRST, but having the wrong size could cause
a truncation bug in the future on 64 bit architectures.

Signed-off-by: Betty Dall <betty.dall@hp.com>
Acked-by: Don Zickus <dzickus@redhat.com>
Link: http://lkml.kernel.org/r/1335559255-13454-1-git-send-email-betty.dall@hp.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
  • Loading branch information
Betty Dall authored and Ingo Molnar committed May 7, 2012
1 parent 72b3fb2 commit 6ff968c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion arch/x86/include/asm/nmi.h
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ typedef int (*nmi_handler_t)(unsigned int, struct pt_regs *);
struct nmiaction {
struct list_head list;
nmi_handler_t handler;
unsigned int flags;
unsigned long flags;
const char *name;
};

Expand Down

0 comments on commit 6ff968c

Please sign in to comment.