Skip to content

Commit

Permalink
ARM: PNX4008: get i2c clock rate from clk API
Browse files Browse the repository at this point in the history
Acked-by: Vitaly Wool <vitalywool@gmail.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
  • Loading branch information
Russell King committed Feb 12, 2010
1 parent ebdbbf2 commit 6fff3da
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 24 deletions.
9 changes: 6 additions & 3 deletions arch/arm/mach-pnx4008/clock.c
Original file line number Diff line number Diff line change
Expand Up @@ -638,29 +638,32 @@ static struct clk flash_ck = {
static struct clk i2c0_ck = {
.name = "i2c0_ck",
.parent = &per_ck,
.flags = NEEDS_INITIALIZATION,
.flags = NEEDS_INITIALIZATION | FIXED_RATE,
.enable_shift = 0,
.enable_reg = I2CCLKCTRL_REG,
.rate = 13000000,
.enable = clk_reg_enable,
.disable = clk_reg_disable,
};

static struct clk i2c1_ck = {
.name = "i2c1_ck",
.parent = &per_ck,
.flags = NEEDS_INITIALIZATION,
.flags = NEEDS_INITIALIZATION | FIXED_RATE,
.enable_shift = 1,
.enable_reg = I2CCLKCTRL_REG,
.rate = 13000000,
.enable = clk_reg_enable,
.disable = clk_reg_disable,
};

static struct clk i2c2_ck = {
.name = "i2c2_ck",
.parent = &per_ck,
.flags = NEEDS_INITIALIZATION,
.flags = NEEDS_INITIALIZATION | FIXED_RATE,
.enable_shift = 2,
.enable_reg = USB_OTG_CLKCTRL_REG,
.rate = 13000000,
.enable = clk_reg_enable,
.disable = clk_reg_disable,
};
Expand Down
9 changes: 0 additions & 9 deletions arch/arm/mach-pnx4008/i2c.c
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,6 @@
#include <mach/irqs.h>
#include <mach/i2c.h>

static u32 calculate_input_freq(struct platform_device *pdev)
{
return HCLK_MHZ;
}


static struct i2c_pnx_algo_data pnx_algo_data0 = {
.base = PNX4008_I2C1_BASE,
.irq = I2C_1_INT,
Expand Down Expand Up @@ -54,17 +48,14 @@ static struct i2c_adapter pnx_adapter2 = {
};

static struct i2c_pnx_data i2c0_data = {
.calculate_input_freq = calculate_input_freq,
.adapter = &pnx_adapter0,
};

static struct i2c_pnx_data i2c1_data = {
.calculate_input_freq = calculate_input_freq,
.adapter = &pnx_adapter1,
};

static struct i2c_pnx_data i2c2_data = {
.calculate_input_freq = calculate_input_freq,
.adapter = &pnx_adapter2,
};

Expand Down
15 changes: 4 additions & 11 deletions drivers/i2c/busses/i2c-pnx.c
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
#define I2C_PNX_TIMEOUT 10 /* msec */
#define I2C_PNX_SPEED_KHZ 100
#define I2C_PNX_REGION_SIZE 0x100
#define PNX_DEFAULT_FREQ 13 /* MHz */

static inline int wait_timeout(long timeout, struct i2c_pnx_algo_data *data)
{
Expand Down Expand Up @@ -578,7 +577,7 @@ static int __devinit i2c_pnx_probe(struct platform_device *pdev)
unsigned long tmp;
int ret = 0;
struct i2c_pnx_algo_data *alg_data;
int freq_mhz;
unsigned long freq;
struct i2c_pnx_data *i2c_pnx = pdev->dev.platform_data;

if (!i2c_pnx || !i2c_pnx->adapter) {
Expand All @@ -599,14 +598,6 @@ static int __devinit i2c_pnx_probe(struct platform_device *pdev)
goto out_drvdata;
}

if (i2c_pnx->calculate_input_freq)
freq_mhz = i2c_pnx->calculate_input_freq(pdev);
else {
freq_mhz = PNX_DEFAULT_FREQ;
dev_info(&pdev->dev, "Setting bus frequency to default value: "
"%d MHz\n", freq_mhz);
}

init_timer(&alg_data->mif.timer);
alg_data->mif.timer.function = i2c_pnx_timeout;
alg_data->mif.timer.data = (unsigned long)i2c_pnx->adapter;
Expand All @@ -632,6 +623,8 @@ static int __devinit i2c_pnx_probe(struct platform_device *pdev)
if (ret)
goto out_unmap;

freq = clk_get_rate(alg_data->clk);

/*
* Clock Divisor High This value is the number of system clocks
* the serial clock (SCL) will be high.
Expand All @@ -643,7 +636,7 @@ static int __devinit i2c_pnx_probe(struct platform_device *pdev)
* the deglitching filter length.
*/

tmp = ((freq_mhz * 1000) / I2C_PNX_SPEED_KHZ) / 2 - 2;
tmp = ((freq / 1000) / I2C_PNX_SPEED_KHZ) / 2 - 2;
iowrite32(tmp, I2C_REG_CKH(alg_data));
iowrite32(tmp, I2C_REG_CKL(alg_data));

Expand Down
1 change: 0 additions & 1 deletion include/linux/i2c-pnx.h
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ struct i2c_pnx_algo_data {
};

struct i2c_pnx_data {
u32 (*calculate_input_freq) (struct platform_device *pdev);
struct i2c_adapter *adapter;
};

Expand Down

0 comments on commit 6fff3da

Please sign in to comment.