Skip to content

Commit

Permalink
Staging: hv: storvsc: No need to copy from bounce buffer in case of a…
Browse files Browse the repository at this point in the history
… failure

No need to copy from bounce buffer in case of a failure; cleanup the code
accordingly.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
K. Y. Srinivasan authored and Greg Kroah-Hartman committed Aug 29, 2011
1 parent 2544b79 commit 70691ec
Showing 1 changed file with 2 additions and 10 deletions.
12 changes: 2 additions & 10 deletions drivers/staging/hv/storvsc_drv.c
Original file line number Diff line number Diff line change
Expand Up @@ -1315,17 +1315,9 @@ static int storvsc_queuecommand_lck(struct scsi_cmnd *scmnd,
if (ret == -EAGAIN) {
/* no more space */

if (cmd_request->bounce_sgl_count) {
/*
* FIXME: We can optimize on writes by just skipping
* this
*/
copy_from_bounce_buffer(scsi_sglist(scmnd),
cmd_request->bounce_sgl,
scsi_sg_count(scmnd));
if (cmd_request->bounce_sgl_count)
destroy_bounce_buffer(cmd_request->bounce_sgl,
cmd_request->bounce_sgl_count);
}
cmd_request->bounce_sgl_count);

kmem_cache_free(host_dev->request_pool, cmd_request);

Expand Down

0 comments on commit 70691ec

Please sign in to comment.