Skip to content

Commit

Permalink
mfd: Remove __devexit annotation for pm80x_deinit
Browse files Browse the repository at this point in the history
This fixes below section mismatch warning:

  LD      drivers/mfd/built-in.o
WARNING: drivers/mfd/built-in.o(.devinit.text+0x46c): Section mismatch in reference from the function pm800_probe() to the function .devexit.text:pm80x_deinit()
The function __devinit pm800_probe() references
a function __devexit pm80x_deinit().
This is often seen when error handling in the init function
uses functionality in the exit path.
The fix is often to remove the __devexit annotation of
pm80x_deinit() so it may be used outside an exit section.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
  • Loading branch information
Axel Lin authored and Samuel Ortiz committed Jul 16, 2012
1 parent 46b65a8 commit 706c96b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion drivers/mfd/88pm80x.c
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ int __devinit pm80x_init(struct i2c_client *client,
}
EXPORT_SYMBOL_GPL(pm80x_init);

int __devexit pm80x_deinit(struct i2c_client *client)
int pm80x_deinit(struct i2c_client *client)
{
struct pm80x_chip *chip = i2c_get_clientdata(client);

Expand Down
2 changes: 1 addition & 1 deletion include/linux/mfd/88pm80x.h
Original file line number Diff line number Diff line change
Expand Up @@ -365,5 +365,5 @@ static inline int pm80x_dev_resume(struct device *dev)

extern int pm80x_init(struct i2c_client *client,
const struct i2c_device_id *id) __devinit;
extern int pm80x_deinit(struct i2c_client *client) __devexit;
extern int pm80x_deinit(struct i2c_client *client);
#endif /* __LINUX_MFD_88PM80X_H */

0 comments on commit 706c96b

Please sign in to comment.