Skip to content

Commit

Permalink
x86: user put_user_x instead of all variants.
Browse files Browse the repository at this point in the history
Follow the pattern, and define a single put_user_x, instead
of defining macros for all available sizes. Exception is
put_user_8, since the "A" constraint does not give us enough
power to specify which register (a or d) to use in the 32-bit
common case.

Signed-off-by: Glauber Costa <gcosta@redhat.com>
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
Glauber Costa authored and Ingo Molnar committed Jul 9, 2008
1 parent 268cf04 commit 70706e4
Showing 1 changed file with 7 additions and 18 deletions.
25 changes: 7 additions & 18 deletions include/asm-x86/uaccess_32.h
Original file line number Diff line number Diff line change
Expand Up @@ -186,25 +186,14 @@ extern void __put_user_2(void);
extern void __put_user_4(void);
extern void __put_user_8(void);

#define __put_user_1(x, ptr) \
asm volatile("call __put_user_1" : "=a" (__ret_pu) \
: "0" ((typeof(*(ptr)))(x)), "c" (ptr) : "ebx")

#define __put_user_2(x, ptr) \
asm volatile("call __put_user_2" : "=a" (__ret_pu) \
: "0" ((typeof(*(ptr)))(x)), "c" (ptr) : "ebx")

#define __put_user_4(x, ptr) \
asm volatile("call __put_user_4" : "=a" (__ret_pu) \
: "0" ((typeof(*(ptr)))(x)), "c" (ptr) : "ebx")
#define __put_user_x(size, x, ptr) \
asm volatile("call __put_user_" #size : "=a" (__ret_pu) \
:"0" ((typeof(*(ptr)))(x)), "c" (ptr) : "ebx")

#define __put_user_8(x, ptr) \
asm volatile("call __put_user_8" : "=a" (__ret_pu) \
: "A" ((typeof(*(ptr)))(x)), "c" (ptr) : "ebx")

#define __put_user_X(x, ptr) \
asm volatile("call __put_user_X" : "=a" (__ret_pu) \
: "c" (ptr): "ebx")

/**
* put_user: - Write a simple value into user space.
Expand Down Expand Up @@ -232,19 +221,19 @@ extern void __put_user_8(void);
__pu_val = x; \
switch (sizeof(*(ptr))) { \
case 1: \
__put_user_1(__pu_val, ptr); \
__put_user_x(1, __pu_val, ptr); \
break; \
case 2: \
__put_user_2(__pu_val, ptr); \
__put_user_x(2, __pu_val, ptr); \
break; \
case 4: \
__put_user_4(__pu_val, ptr); \
__put_user_x(4, __pu_val, ptr); \
break; \
case 8: \
__put_user_8(__pu_val, ptr); \
break; \
default: \
__put_user_X(__pu_val, ptr); \
__put_user_x(X, __pu_val, ptr); \
break; \
} \
__ret_pu; \
Expand Down

0 comments on commit 70706e4

Please sign in to comment.