Skip to content

Commit

Permalink
drivers/net/wan: delete unneeded call to netdev_priv
Browse files Browse the repository at this point in the history
Netdev_priv is an accessor function, and has no purpose if its result is
not used.

A simplified version of the semantic match that fixes this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@@ local idexpression x; @@
-x = netdev_priv(...);
... when != x
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Julia Lawall authored and David S. Miller committed May 15, 2014
1 parent dab531b commit 7077f22
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions drivers/net/wan/sdla.c
Original file line number Diff line number Diff line change
Expand Up @@ -1322,10 +1322,6 @@ NOTE: This is rather a useless action right now, as the

static int sdla_change_mtu(struct net_device *dev, int new_mtu)
{
struct frad_local *flp;

flp = netdev_priv(dev);

if (netif_running(dev))
return -EBUSY;

Expand Down

0 comments on commit 7077f22

Please sign in to comment.